fix: trigger initial divina scroll preload on iOS#723
Merged
Conversation
Run the reader page preload pass immediately after the initial scroll position is synchronized in the iOS DIVINA scroll view. This aligns the iOS initialization path with macOS so the next page is warmed before the first manual page turn, avoiding the transient loading flash on page two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On iOS, opening the DIVINA reader in scroll mode on the first page could leave the second page outside the initial preload window. The first manual page turn then had to fetch and decode that page on demand, which showed a brief loading state.
Approach
Trigger the regular page preload pass immediately after the initial scroll position is synchronized in the iOS scroll reader. This keeps the fix on the existing preload architecture and aligns the iOS initialization path with the macOS path that already warms adjacent pages at first presentation.
Scope
ScrollPageViewinitial-position sync path to force the first preload pass once the committed item is knownValidation
make formatmake build-ios