refactor: move divina cover reader to native containers#725
Merged
Conversation
Replace the SwiftUI-driven DIVINA cover path with native UIKit and AppKit cover containers, shared paged page content views, and native slot management. Fix stale loading state, reduce redundant slot refreshes, and correct first-transition animation issues on iOS and macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The DIVINA cover reader was still driven by a SwiftUI cover path, which left it exposed to stale loading state, unnecessary slot refreshes, and first-transition animation glitches that did not affect the native scroll and page-curl readers.
Approach
Replace the cover-mode presentation with native UIKit and AppKit container implementations that own deck state, gestures, and animations directly. Reuse shared native paged page-content views so cover, scroll, and page-curl paths render through the same lower-level page presentation code, then tighten slot updates so stable-state refreshes do not reconfigure unchanged slots.
Scope
Validation
make formatmake build