fix(trace): handle all header flag formats and missing secret headers in redaction#1009
Merged
fix(trace): handle all header flag formats and missing secret headers in redaction#1009
Conversation
…ders in redaction Closes #1002 — redact_argv now handles --user/-u flags, --header=value and -Hvalue concatenated forms, and adds cookie, proxy-authorization, set-cookie, x-csrf-token to the secret headers list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--user/-uflags (redact next argument)--header=valueconcatenated form-Hvalueconcatenated formcookie,proxy-authorization,set-cookie,x-csrf-tokenWhat & Why
redact_argvonly handled-H/--headeras standalone flags. Credentials passed via--user admin:pass,-HAuthorization: Bearer token, or--header=Authorization: Bearer tokenwere not redacted, leaking to trace output.Tests Added
test_redact_user_flag/test_redact_short_user_flagtest_redact_header_equals_formtest_redact_concatenated_h_flagtest_redact_cookie_headertest_redact_proxy_authorizationCloses #1002