fix(builtins): harden curl redirect against credential leaks#1020
Merged
fix(builtins): harden curl redirect against credential leaks#1020
Conversation
Closes #998 — Three fixes for curl redirect handling: 1. Strip Authorization/Cookie headers on cross-origin redirects 2. Convert POST to GET on 301/302/303 (drop body per HTTP spec) 3. Preserve port in resolve_redirect_url for absolute-path redirects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authorization,Cookie,Proxy-Authorizationheaders on cross-origin redirectsresolve_redirect_urlfor absolute-path redirectsCloses #998
Test plan
cargo clippy -- -D warningscleancargo fmt --checkclean