fix(builtins): read builtin now respects custom IFS for field splitting#1024
Merged
fix(builtins): read builtin now respects custom IFS for field splitting#1024
Conversation
The read builtin was only checking env variables for IFS, missing shell variables set via IFS=",". Now checks shell variables first, then env. Also fixes the last-variable join to use the IFS delimiter instead of hardcoded space. Closes #968
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readbuiltin to check shell variables for IFS (not just env variables)Why
IFS=","sets a shell variable, butreadonly checkedctx.env(exported env). This causedIFS=","; read -r a b c <<< "1,2,3"to put the entire input intoa.Tests
read_ifs_from_shell_variables,read_ifs_from_shell_variables_arrayread_custom_ifsto expect correct IFS-delimited join (bar:baznotbar baz)read_custom_ifs_comma,read_custom_ifs_colonCloses #968