fix(echo): support combined flags and fix test expectations#106
Merged
Conversation
- Add support for combined flags like -en, -ne, -neE in echo builtin - Fix echo_escape_octal test to use correct \0nnn format (bash echo format) - Enable 5 previously skipped echo tests: - echo_combined_en, echo_combined_ne (combined flags) - echo_E_flag (-E flag already worked) - echo_escape_hex, echo_escape_octal (escapes already worked) Test results: 330/435 spec tests passing, 309/309 match real bash https://claude.ai/code/session_014PwJPpXSYYYszKvRD16Npx
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-en,-ne,-neEin echo builtin\0nnnformat (bash echo uses this format)Changes
echo.rs: Refactor flag parsing to handle combined optionsecho.test.sh: Enable 5 tests and fix octal escape test expectationspec_tests.rs: Update TODO tracking comments004-testing.md: Update test countsTest plan
cargo test --features http_clientpassescargo test --test spec_tests -- bash_comparison_testspasses (309/309 match real bash)https://claude.ai/code/session_014PwJPpXSYYYszKvRD16Npx