feat(cli): relax execution limits for CLI mode#1076
Merged
Conversation
CLI/script modes now use ExecutionLimits::cli() which removes counting-based limits (commands, loop iterations) and timeout — the user explicitly chose to run the script and has Ctrl-C. Stdout/stderr caps raised to 10 MB. Memory-guarding limits (function depth, AST depth, parser fuel) are kept. MCP mode retains the sandboxed defaults since requests come from LLM agents. The --max-commands, --max-loop-iterations, --max-total-loop-iterations, and --timeout flags remain as overrides for both modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecutionLimits::cli()— counting-based limits (max commands, loop iterations) are effectively unlimited and no timeout is appliedExecutionLimits::new())--max-loop-iterations,--max-total-loop-iterations, and--timeoutallow overriding the defaults when neededTest plan
cargo fmt --check— cleancargo clippy -p bashkit -p bashkit-cli --all-features -- -D warnings— no warningscargo test -p bashkit-cli --all-features— 30/30 pass