fix(ci): fix crates.io publish + add verification#1126
Merged
Conversation
… crate cargo publish resolves the whole workspace, so bashkit-cli's dependency on bashkit with features=["python"] must be stripped before publishing bashkit core (not just in the bashkit-cli job). Also: - Remove silent error swallowing (|| echo warning) from bashkit publish - Add verify-publish job to publish.yml that checks crates.io versions - Add npm publish verification step to publish-js.yml - Update release spec with post-release verification commands
3 tasks
chaliy
added a commit
that referenced
this pull request
Apr 6, 2026
#1127) ## Summary Strip python feature from **all** workspace crates (bashkit-js, bashkit-python) before publishing bashkit core. Previous fix only covered bashkit-cli but cargo resolves the whole workspace. ## Context Follow-up to #1126. Re-triggering `publish.yml` still failed because `bashkit-js` and `bashkit-python` also depend on `bashkit` with `features = ["python"]`. ## Test plan - [ ] CI green - [ ] Re-trigger `publish.yml` from main after merge - [ ] `cargo search bashkit` shows 0.1.16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo publishfailures were hidden by|| echo "::warning::"— bashkit core 0.1.16 silently failed to publish to crates.ioverify-publishjob in publish.yml checks crates.io, npm verification step in publish-js.ymlContext
v0.1.16 published to npm and PyPI but not to crates.io. The
cargo publish -p bashkitstep failed because cargo resolves the whole workspace, and bashkit-cli still referencedbashkitwithfeatures = ["python"](which was stripped). The error was swallowed by|| echo "::warning::".Test plan
publish.ymlto publish bashkit 0.1.16 to crates.io