feat(js): readDir returns entries with metadata (Python parity)#1132
Merged
feat(js): readDir returns entries with metadata (Python parity)#1132
Conversation
Bash.readDir() and BashTool.readDir() now return JsDirEntry objects with name and metadata (fileType, size, mode, etc.) instead of plain strings. This matches the Python bindings' read_dir behavior and the JsFileSystem.readDir() API. All other missing operations (stat, appendFile, chmod, symlink, readLink) already exist on the Bash class. Added comprehensive VFS API tests covering stat, readDir, appendFile, chmod, symlink, readLink, and the fs() accessor. Closes #1129
wrapper.ts ls() methods return string[] by mapping JsDirEntry.name from the now-rich readDir results.
… fs on wrapper Both Bash and BashTool wrapper classes now expose all VFS operations that the native NAPI class provides, achieving full Python parity.
readFile via direct API doesn't follow symlinks; use bash cat which does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bash.readDir()andBashTool.readDir()now returnJsDirEntryobjects withnameandmetadata(fileType, size, mode, timestamps) instead of plain stringsread_dirbehavior and the existingJsFileSystem.readDir()APIstat,appendFile,chmod,symlink,readLink,fs()) already exist on theBashclassTest plan
stat returns file metadatastat returns directory metadatareadDir returns entries with metadataappendFile appends contentchmod changes file modesymlink and readLink roundtripfs() accessor provides same operationsCloses #1129