fix(tar): pass -C directory to create_tar for VFS file resolution#1135
Merged
fix(tar): pass -C directory to create_tar for VFS file resolution#1135
Conversation
create_tar() never received the change_dir parameter from -C flag, so file paths were resolved relative to cwd instead of the specified directory. Now resolves files relative to -C path when provided. Closes #1118
Now that tar -c correctly uses -C directory, the creation step needs more headroom since it actually reads source files via VFS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_tar()never received thechange_dirparameter from-Cflagcwdinstead of the-Cdirectory-Cpath when provided, matching extract behaviorTest plan
tar_create_basic— basic archive creation from VFS filestar_create_with_C_flag—-Cresolves files correctlytar_create_gzip—-czfcreates gzip archiveCloses #1118