fix(git): sanitize control characters in git output#1210
Merged
Conversation
Strip ANSI escape sequences, null bytes, and C0/C1 control characters from git output before it reaches interpreter stdout. Prevents terminal injection via crafted repository metadata (branch names, commit messages, config values, file paths). Addresses TM-GIT-015. Closes #1187.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitize_git_output()function ingit/mod.rsthat strips ANSI escape sequences, null bytes, DEL, and C0/C1 control characters while preserving tab, newline, and carriage returnformat_branch_list(),format_log(),format_status(),config_get(),grep(),rev_parse(), andshow()Fixes #1187 (TM-GIT-015)
Test plan
cargo test -p bashkit --lib git::tests— all 9 sanitization tests passcargo test -p bashkit --features git— full test suite passes (95 passed)cargo fmt --check— cleancargo clippy -p bashkit --features git -- -D warnings— no new warnings (pre-existing dead code in curl.rs)