fix(date): preserve spaces in format string from variable expansion#1211
Merged
fix(date): preserve spaces in format string from variable expansion#1211
Conversation
When a word mixes unquoted literal and double-quoted expansion (e.g. +"$fmt"), the lexer now promotes it to QuotedWord so the interpreter suppresses IFS field splitting — matching POSIX behaviour where double-quoted expansions never undergo splitting. Previously +"$fmt" with fmt="%B %d, %Y" was word-split into three arguments ["+%B", "%d,", "%Y"], so only %B was used. Closes #1203
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
date +"$var"when the variable contains spacesToken::Wordfor mixed-quoted words like+"$fmt", causing IFS field splitting on expansionToken::WordtoToken::QuotedWord, suppressing field splitting (matches POSIX behavior)Closes #1203
Test plan
test_date_format_var_with_spaces_no_split— verifiesdate +"$fmt"with spaces produces correct outputtest_mixed_quote_prefix_var_no_split— verifies genericprefix"$var"pattern preserves spaces