fix(limits): treat zero limit values as "use default"#1216
Merged
Conversation
…pting Passing 0 to any numeric limit setter (max_commands, max_loop_iterations, etc.) now silently keeps the default value instead of setting the limit to zero. This prevents misconfiguration where a caller passes 0 intending "unlimited" but actually disables or over-restricts execution. Applied to all numeric setters on ExecutionLimits, SessionLimits, and MemoryLimits. Duration and bool setters are unchanged. Closes #1181
Tests that used max_stdout_bytes(0) or max_ast_depth(0) now use small nonzero values since zero is treated as "use default" per #1181.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1181
max_commands,max_loop_iterations, etc.) to treat0as "use default" instead of accepting itExecutionLimits,SessionLimits, andMemoryLimitsbuilder methodstimeout(),parser_timeout(), andcapture_final_env()are unchanged (non-numeric)Test plan
test_zero_limit_uses_default— all ExecutionLimits setters with 0 keep defaultstest_nonzero_limit_works— nonzero values are applied correctlytest_session_limits_zero_uses_default— SessionLimits zero-guardtest_memory_limits_zero_uses_default— MemoryLimits zero-guard