Skip to content

fix(vfs): emit warnings when tar extraction skips unsupported entry types#1217

Merged
chaliy merged 1 commit intomainfrom
fix/1178-tar-symlink-warning
Apr 11, 2026
Merged

fix(vfs): emit warnings when tar extraction skips unsupported entry types#1217
chaliy merged 1 commit intomainfrom
fix/1178-tar-symlink-warning

Conversation

@chaliy
Copy link
Copy Markdown
Contributor

@chaliy chaliy commented Apr 11, 2026

Summary

  • Tar extraction now warns on stderr when symlink (type 2), hard link (type 1), and other unsupported entry types (char/block devices, FIFOs, etc.) are skipped during extraction
  • Previously these entries were silently discarded with no indication to the user
  • Added three tests: test_tar_extract_symlink_warning, test_tar_extract_hardlink_warning, test_tar_extract_unsupported_type_warning

Closes #1178

Test plan

  • cargo test -p bashkit -- tar — all 23 tar tests pass (13 existing + 3 new)
  • cargo fmt --check — clean
  • cargo clippy --all-targets --all-features -- -D warnings — clean

@chaliy chaliy merged commit 4852601 into main Apr 11, 2026
27 checks passed
@chaliy chaliy deleted the fix/1178-tar-symlink-warning branch April 11, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sec(vfs): tar extraction symlink type silently skipped — no warning when archive contains symlink attacks

1 participant