fix(interpreter): filter SHOPT_ variables from set/declare output#1218
Merged
fix(interpreter): filter SHOPT_ variables from set/declare output#1218
Conversation
…re output SHOPT_* variables (e.g. SHOPT_e, SHOPT_pipefail) are internal implementation details used to track shell options. They were visible via `set` and `declare -p`, enabling implementation fingerprinting. Add SHOPT_ prefix to is_internal_variable() and add security tests verifying both `set` and `declare -p` filter these variables. Closes #1186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1186
SHOPT_prefix tois_internal_variable()filter to prevent implementation fingerprintingSHOPT_*variables (e.g.SHOPT_e,SHOPT_pipefail) are internal bookkeeping and should not appear insetordeclare -poutputTest plan
security_audit_set_hides_shopt_vars— verifiessetoutput has noSHOPT_variablessecurity_audit_declare_p_hides_shopt_vars— verifiesdeclare -poutput has noSHOPT_variablesinternal_variable_leaksecurity tests pass