fix(logging): add runtime guard for unsafe logging methods#1219
Merged
Conversation
unsafe_disable_redaction() and unsafe_log_scripts() now require BASHKIT_UNSAFE_LOGGING=1 env var to take effect. Without it they are no-ops that emit a warning to stderr. Prevents accidental use in production. Closes #1179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1179
unsafe_disable_redaction()andunsafe_log_scripts()now requireBASHKIT_UNSAFE_LOGGING=1env var to take effectTest plan
test_unsafe_methods_noop_without_env— verifies both methods are no-ops without env vartest_disabled_redaction— verifies methods work with env var settest_script_formatting— verifies script logging works with env var