fix(mcp): sanitize JSON-RPC error responses#1220
Merged
Conversation
…akage Replace raw serde_json error details in JSON-RPC error responses with generic messages. Internal details (struct names, field names, line/column numbers) are now logged to stderr for operator debugging but never sent to the client. Closes #1182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1182
"Parse error: invalid JSON""Invalid arguments"Test plan
test_parse_error_does_not_leak_internal_details— malformed JSON returns generic errortest_invalid_arguments_does_not_leak_struct_names— wrong fields return generic error