refactor(deps): simplify dependency tree#1223
Merged
Conversation
- Remove unused workspace deps: grep, grep-regex, grep-searcher, globset - Remove unused `instant` from bashkit-bench (fixes RUSTSEC-2024-0384) - Feature-gate jaq-core/jaq-std/jaq-json behind new `jq` feature flag - Replace `futures` with `futures-core` + `futures-util` (drops 5 sub-crates) - Enable `jq` feature in CLI, JS, Python, and eval crates Minimal build (no features) drops from 227 to 173 dep lines (-24%).
Ensures dead deps, ungated single-use deps, bloated crates, and duplicate transitive versions are caught during every maintenance pass.
chaliy
force-pushed
the
claude/simplify-dependencies-Wgr1O
branch
from
3d6571e to
f1850e1
Compare
2 tasks
chaliy
added a commit
that referenced
this pull request
Apr 11, 2026
test_text_file_json requires the jq feature (gated in #1223) but CI runs with --features http_client,ssh. Add #[cfg(feature = "jq")] to skip when jq is not compiled in.
chaliy
added a commit
that referenced
this pull request
Apr 11, 2026
jq_fuzz_scaffold_tests, jq_spec_tests, and azure skill tests that use jq need #[cfg(feature = "jq")] since #1223 feature-gated jaq deps.
chaliy
added a commit
that referenced
this pull request
Apr 11, 2026
Scan /dev/fd for proc_sub_* files after each Bash::exec() call. Cleanup runs outside the recursive async call chain to avoid increasing stack frame size (which would regress #1089 stack overflow). Also restore tests deleted by previous commit, revert #[ignore] on ssh_supabase test, and gate jq-dependent tests behind #[cfg(feature = "jq")] since #1223 feature-gated jaq deps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grep,grep-regex,grep-searcher(never used — grep builtin usesregexdirectly),globset(never imported in source)instantfrom bashkit-bench (code usesstd::time::Instant); also removes RUSTSEC-2024-0384 advisory from deny.tomljaq-core/jaq-std/jaq-jsonbehind newjqfeature flag (only used inbuiltins/jq.rs)futureswithfutures-core+futures-util(drops 5 unused sub-crates)specs/012-maintenance.md)Minimal build (no features) drops from 227 to 173 dep lines (-24%).
Test plan
cargo check --all-targets --all-features— cleancargo check -p bashkit --no-default-features— clean (verifies jq gating)cargo test --all-features— all pass (except pre-existing SSH integration test)cargo fmt --check— cleancargo clippy --all-targets --all-features -- -D warnings— clean