fix(python): add mutex timeout to prevent execute_sync deadlock#1229
Merged
fix(python): add mutex timeout to prevent execute_sync deadlock#1229
Conversation
Closes #1173 — execute_sync() now uses tokio::time::timeout (30s) on the async mutex acquisition. Prevents deadlocks when multiple Python threads call execute_sync concurrently. Raises RuntimeError with guidance to use separate instances for concurrent workloads.
chaliy
force-pushed
the
fix/issue-1173-python-deadlock
branch
from
76e4f6f to
31ebdb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1173
execute_sync()on bothBashandBashToolnow usestokio::time::timeout(30s) on mutex acquisitionRuntimeErrorwith clear guidance to use separate instances for concurrencyTest plan
cargo check -p bashkit-python)RuntimeErrorinstead of indefinite hang