fix(cli): emit warning when --mount-rw is used in MCP mode#1237
Merged
Conversation
LLM agents in MCP mode should not silently get read-write access to host filesystem. Emit a loud stderr warning recommending --mount-ro. Closes #1165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- Emit a loud stderr warning when
--mount-rwis combined withmcpsubcommand, since LLM agents would get read-write host filesystem access\n- Add TM-ESC-030 to threat model for mount-rw + MCP combination\n- Add tests verifying warning triggers for rw mounts in MCP mode and not for ro mounts\n\n## Test plan\n\n- [x]mount_rw_mcp_mode_emits_warning— verifies configure_bash succeeds with warning path\n- [x]mount_ro_mcp_mode_no_warning— verifies ro mounts in MCP mode don't trigger warning\n- [x]cargo clippyandcargo fmtclean\n\nCloses #1165