fix(template): prevent injection via #each data values#1240
Merged
Conversation
Escape {{ in data values before substitution so template directives
embedded in JSON data are not re-evaluated. Uses a sentinel that is
restored after rendering, preserving literal {{ in output.
Closes #1164
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- Escape
{{in data values before substitution in#eachblocks using a sentinel\n- Sentinel is restored afterrender_template_innerso literal{{is preserved in output\n- JSON data containing{{SECRET_KEY}}now produces the literal string, not the variable's value\n\n## Test plan\n\n- [x]test_each_data_injection_blocked— secret variable not leaked through data\n- [x]test_each_nested_directive_in_data_not_evaluated—{{#if}}in data preserved literally\n- [x] Existingtest_each_blockstill passes\n- [x]cargo clippyandcargo fmtclean\n\nCloses #1164