fix(mount): add path validation, allowlist, and writable warnings#1252
Merged
fix(mount): add path validation, allowlist, and writable warnings#1252
Conversation
chaliy
force-pushed
the
fix/issue-1169-mount-path-validation
branch
2 times, most recently
from
792afdb to
9495fd8
Compare
- Add optional mount path allowlist via allowed_mount_paths() builder - Block sensitive host paths by default (/etc/shadow, /proc, /sys, etc.) - Warn on stderr when writable mounts are created (Rust, JS bindings) - Python bindings inherit validation through the Rust builder Closes #1169
chaliy
force-pushed
the
fix/issue-1169-mount-path-validation
branch
from
9495fd8 to
e9a9e32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowed_mount_paths()builder method/etc/shadow,/etc/sudoers,/proc,/sys)Test plan
/procis blocked by defaultcargo clippycleanCloses #1169