feat(credential): generic credential injection for outbound HTTP requests#1282
Merged
feat(credential): generic credential injection for outbound HTTP requests#1282
Conversation
…ests Add transparent per-host credential injection so sandboxed scripts can make authenticated API calls without ever seeing the real secrets. Two modes: - Injection: headers added automatically based on URL pattern - Placeholder: opaque env var replaced with real credential on the wire Built on the before_http hooks system (#1255). Credential policy hook runs first so subsequent hooks see injected headers. Injected headers overwrite existing headers with the same name (prevents spoofing). New files: - specs/019-credential-injection.md (design spec) - crates/bashkit/src/credential.rs (Credential, CredentialPolicy) - crates/bashkit/docs/credential-injection.md (rustdoc guide) - crates/bashkit/tests/credential_injection_tests.rs (13 integration tests)
The function was pub(crate) but only used by client.rs (behind the git feature gate). Without the git feature, it was dead code. Gate it with #[cfg(any(feature = "git", test))] so tests still compile.
cd38eb0 to
ff4ec88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
before_httphooks system (feat(hooks): wire tool hooks into builtin pipeline, add HTTP hooks #1255) — credential policy hook runs first, injected headers overwrite existing ones (prevents spoofing)Credentialenum,BashBuilder::credential()andBashBuilder::credential_placeholder()APIsAPI
New files
specs/019-credential-injection.mdcrates/bashkit/src/credential.rsCredential,CredentialPolicy, unit testscrates/bashkit/docs/credential-injection.mdcrates/bashkit/tests/credential_injection_tests.rsTest plan
cargo fmt --checkcleancargo clippyclean (only pre-existingdead_codeingit/mod.rs)