ci(node): add TypeScript type-check job to JS workflow#1289
Merged
Conversation
Add a `typecheck` job that runs `tsc --noEmit` against all source and test files via a new `tsconfig.check.json`. The check config extends the base tsconfig and additionally includes `__test__/**/*.spec.ts` so test files are also type-checked (the base config excludes them since they are not shipped). The job is wired into the `js-check` gate so branch protection will block merges when type errors are present. Closes #1268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typecheckjob to.github/workflows/js.ymlthat runstsc --noEmittsconfig.check.jsonthat extendstsconfig.jsonto also cover test files (__test__/*.spec.ts)js-checkgate for branch protectionDetails
The Node CI now mirrors the Python CI pattern of having a dedicated lint/type-check job. The typecheck job:
index.d.ctstype declarationstsc --noEmit -p tsconfig.check.jsonjs-checkgate jobTest plan
tsconfig.check.jsonextends base config and includes test filesCloses #1268