fix(python): cover issue 1264 security gaps#1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bash.read_file()/write_file()/ls()/glob()cases$PPIDresolves to a virtual parent PID and add a regression testRealFsfallback paths against the canonical root and gatinghttp_client-only hook testsTesting
/private/tmp/bashkit-1264-venv/bin/pytest crates/bashkit-python/tests/test_security.py -q/private/tmp/bashkit-1264-venv/bin/ruff check crates/bashkit-python/tests/test_security.py/private/tmp/bashkit-1264-venv/bin/ruff format --check crates/bashkit-python/tests/test_security.pycargo test -p bashkit --features http_client default_ppid_is_sandboxed -- --nocapturecargo test -p bashkit resolve_fallback_validates_containment -- --nocapturecargo test -p bashkit resolve_fallback_returns_normalized_path -- --nocapturejust pre-pr(locally blocked onbash_comparison_tests; reproduced on cleanorigin/mainin a detached worktree on this macOS machine)Closes #1264.