fix(ci): avoid duplicate example builds in test job#1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CItest job from rebuilding examples duringcargo testExamplesjobWhy
mainwent red on GitHub Actions run24465694329for commite51470abecause theTestjob exhausted runner disk while linkingpython_scriptsduringcargo test --features http_client,ssh.That job was compiling examples even though examples already have their own dedicated workflow job. Splitting the coverage avoids duplicate example links in the
Testjob and removes the disk-pressure path that brokemain.Test Plan
cargo test --workspace --lib --bins --tests --features http_client,ssh --no-runcargo test --workspace --doc --features http_client,sshjust pre-pr(fails on a pre-existingbash_comparison_testsmismatch incargo test; unrelated to this workflow-only change)