feat(parser): add line number support for $LINENO and error messages#132
Merged
feat(parser): add line number support for $LINENO and error messages#132
Conversation
Add comprehensive source location tracking throughout the parser and interpreter: - New Span and Position types for tracking source locations (line/column/offset) - Lexer tracks line/column as it tokenizes, emits SpannedToken - All AST command nodes now include span field - Parser threads spans through to AST nodes - ParseAt error variant includes line/column in error messages - $LINENO variable now returns actual line number from command span - New tests for $LINENO in multiline scripts and loops - Tests for parse error location reporting https://claude.ai/code/session_01Gds1BKwWLE8SPEFN5txZfe
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$LINENOvariable that returns actual line number during executionChanges
Position(line/column/offset) andSpan(start/end positions) inparser/span.rsSpannedTokenwith source locationsspanfieldParseAterror variant includes line/column in messages$LINENOexpansionTest plan
cargo fmt --checkpassescargo clippy --all-targets --all-features -- -D warningspassescargo test --lib --features http_client- 603 tests passcargo test --test spec_tests- 13 tests passhttps://claude.ai/code/session_01Gds1BKwWLE8SPEFN5txZfe