Skip to content

fix(bashkit): gate Path import behind realfs#1497

Merged
chaliy merged 1 commit intomainfrom
fix/conditional-path-import
May 1, 2026
Merged

fix(bashkit): gate Path import behind realfs#1497
chaliy merged 1 commit intomainfrom
fix/conditional-path-import

Conversation

@chaliy
Copy link
Copy Markdown
Contributor

@chaliy chaliy commented May 1, 2026

What

Conditionally import std::path::Path only when the realfs feature is enabled.

Why

Default builds warned that Path was unused because its only runtime use is inside #[cfg(feature = "realfs")] code.

How

Split Path from PathBuf and guard only the Path import with #[cfg(feature = "realfs")].

Risk

  • Low
  • Compile-time-only import change; no runtime behavior change.

Checklist

  • Tests added or updated
  • Backward compatibility considered

Verification:

  • cargo check -p bashkit
  • cargo check -p bashkit --features realfs
  • just pre-pr

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bashkit 86bdc85 Commit Preview URL

Branch Preview URL
May 01 2026, 12:47 AM

@chaliy chaliy merged commit ce7c71c into main May 1, 2026
34 checks passed
@chaliy chaliy deleted the fix/conditional-path-import branch May 1, 2026 00:57
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant