fix(ci): green up failing main-branch tests and example#1506
Merged
Conversation
- ssh/{config,handler}.rs and sqlite/tests.rs: annotate intentional
Debug uses with `// debug-ok:` so the TM-INF-022 source guard
(no_debug_fmt_in_builtin_source) passes. The ssh tests verify that
Debug redacts secrets; the sqlite asserts dump the run result on
failure — both legitimate test-only Debug uses.
- jq tests: tolerate broken-pipe on stdin in run_real_jq so
diff_unknown_flag_exit_code doesn't fall back to exit=-1 when real
jq exits before reading stdin (e.g. on `--xyzzy`).
- examples/agent_tool.rs: install rustls' ring crypto provider
before constructing reqwest::Client. reqwest is built with
rustls-no-provider, so without this the example panics with
"No provider set".
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | f474c1b | Commit Preview URL Branch Preview URL |
May 02 2026, 03:35 PM |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
mainwas red acrossTest,Coverage, andExamples. Three independent root causes — fixed each:no_debug_fmt_in_builtin_source) — six legitimate Debug uses inssh/{config,handler}.rsandsqlite/tests.rswere missing the// debug-ok: <reason>marker that the static guard requires. Annotated each: the ssh tests assert that Debug redacts secrets (the Debug call IS the test), and the sqlite asserts dump the run result on assertion failure.jq::tests::differential::diff_unknown_flag_exit_code—run_real_jqreturnedNonewhen real jq exited before reading stdin (broken pipe on--xyzzy), and the test fell back toexit=-1, never matching bashkit's2. Drop stdin and ignore the write error sowait_with_outputstill produces the real exit code.agent_toolexample panicked with "No provider set" — reqwest is built withrustls-no-provider, so aCryptoProvidermust be installed beforereqwest::Client::new(). Install ring at the top ofmain(), mirroring whatnetwork::client::install_default_crypto_providerdoes for the library.Test plan
cargo test -p bashkit --lib no_debug_fmt_in_builtin_source(was red, now green)cargo test -p bashkit --lib differential::diff_unknown_flag_exit_code(was red, now green)cargo test -p bashkit --lib ssh::config::tests::test_debug_redacts_credentials ssh::handler::tests::test_debug_redacts_credentials sqlite::tests::persistence_round_trip*(still green after annotations)cargo build --example agent_tool --features http_client(compiles)cargo fmt --checkcargo clippy --all-targets --all-features -- -D warningsGenerated by Claude Code