fix(sqlite): invalidate cached engine when VFS file changes#1599
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | d10b2fe | Commit Preview URL | May 08 2026, 09:09 AM |
2ef130a to
d10b2fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
snapshot_bytes()with the currentctx.fs.read_file(path)and force a reopen when the bytes differ or the read fails. (change incrates/bashkit/src/builtins/sqlite/mod.rsaround the file-target path handling):memory:targets (still ephemeral per-invocation). (no behavioural change to memory backend)exec()calls to guard against stale-cache resurrection and overwrite regressions. (added tests incrates/bashkit/tests/sqlite_integration_tests.rs)Testing
cargo test --features sqlite -p bashkit --test sqlite_integration_tests -- cached_engine_respects_, and both tests passed (2 passed, 0 failed).Codex Task