fix(tool_def): reject bare array flags without values#1603
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | f2596d6 | Commit Preview URL | May 08 2026, 09:12 AM |
ca0993f to
f2596d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
--tags) were parsed as present empty arrays ([]) when no value followed, which can let callbacks treat an omitted value as a valid empty array and bypass presence/type checks.Description
consume_array_valueincrates/bashkit/src/tool_def.rsto returnErr(format!("--{flag_name}: missing value"))when the flag has no following token or the next token is another--flag, instead of returning an emptyArrayInput::Items(Vec::new()).test_parse_flags_array_missing_value_is_errorandtest_parse_flags_array_missing_value_before_next_flag_is_errorwhich assert the parser errors with"--tags: missing value"for both end-of-args and next-flag cases.Testing
cargo test -p bashkit parse_flags_array_missing_valueand the new tests passed.cargo test -p bashkit) as part of validation; the test run completed and the new tests and existing filtered tests did not fail.crates/bashkit/src/tool_def.rsand cover the two missing-value scenarios.Codex Task