fix(sqlite): enforce row cap while stepping#1615
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | b798ca8 | Commit Preview URL | May 08 2026, 08:15 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enforce
SqliteLimits::max_rows_per_queryinsideSqliteEngine::executebefore cloning/materialising each returned row.Also threads the same cap through sqlite dot-command queries, including
.dump, and tightens TM-SQL-004 regression coverage.Why
The previous sqlite row cap was checked only after
executereturned, so oversized result sets could be fully materialised in memory before rejection.How
outcome.rows..dumprow-cap tests, plus a stricter black-box TM-SQL-004 case.Risk
Checklist
Verification:
cargo fmt --checkCARGO_BUILD_JOBS=2 CARGO_INCREMENTAL=0 cargo clippy -p bashkit --features sqlite --all-targets -- -D warningsCARGO_BUILD_JOBS=2 CARGO_INCREMENTAL=0 cargo test --features sqlite -p bashkit --lib row_cap -- --nocaptureCARGO_BUILD_JOBS=2 CARGO_INCREMENTAL=0 cargo test --features sqlite -p bashkit --test sqlite_security_tests -- --nocaptureCARGO_BUILD_JOBS=2 CARGO_INCREMENTAL=0 cargo test --features sqlite -p bashkit --libCARGO_BUILD_JOBS=2 CARGO_INCREMENTAL=0 cargo test --all-features -p bashkit --libCARGO_BUILD_JOBS=2 CARGO_INCREMENTAL=0 just pre-prreachedcargo testafter fmt/clippy, then failed during integration-test linking withld: write() failed, errno=28(local disk full), not a test failure.