fix(bashkit-eval): make rustls provider init idempotent#1619
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 71d4fcd | Commit Preview URL | May 09 2026, 09:19 AM |
c0b9c25 to
71d4fcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ensure_rustls_crypto_provider()previously cached anyinstall_default()error in aOnceLock, which breaks callers when a rustls provider was already installed (benign second-install case).Description
ensure_rustls_crypto_provider()to treatinstall_default()failing as success whenCryptoProvider::get_default()is alreadySome, preserving idempotence while keepingOnceLockmemoization.ensure_rustls_provider_succeeds_when_already_installedthat pre-installs the ring provider and asserts the helper returnsOk(()).Testing
cargo test -p bashkit-eval provider::tests::ensure_rustls_provider_succeeds_when_already_installedand the test passed.bashkit-evalpackage tests as part of the run; targeted regression test succeeded.Codex Task