fix(rg): count unrestricted flags independently#1754
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | b8a67bf | Commit Preview URL | May 25 2026, 02:42 AM |
chaliy
added a commit
that referenced
this pull request
May 25, 2026
When -u/--unrestricted is first applied (level 1) it now disables all per-class ignore toggles (no_ignore_dot, no_ignore_exclude, no_ignore_global, no_ignore_parent, no_ignore_vcs) in addition to no_ignore, matching real ripgrep behavior. This way later positive flags such as --ignore-dot can re-enable only their intended class. Adds a differential regression case '-u --ignore-dot'. Rebased on current main on top of #1754; original PR #1751 by chaliy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
-u/--unrestrictedadvanced behavior by inspecting currentno_ignore/hiddenbooleans, causing explicit--no-ignore/--hiddenflags to incorrectly consume unrestricted levels and producing order-dependent semantics.Description
unrestricted_level: u8field toRgOptionsand initialize it inRgOptions::parseso unrestricted usage is tracked independently of explicit flags.apply_unrestricted()logic to incrementunrestricted_leveland map levels1 => no_ignore,2 => hidden,>=3 => binaryto match ripgrep semantics regardless of flag order.rgtest cases to cover--no-ignore -uand--hidden -uuso explicit flags do not advance unrestricted levels.fix(rg): count unrestricted flags independently.Testing
cargo test -p bashkit rg::tests::rg_real_diff_unrestricted -- --nocapture, and the test completed successfully.Codex Task