fix(ci): add --allow-dirty for cargo publish after stripping monty#209
Merged
fix(ci): add --allow-dirty for cargo publish after stripping monty#209
Conversation
monty ^0.0.6 only exists on GitHub (crates.io has 0.0.0). cargo publish resolves all deps from registry, including optional ones, causing the v0.1.5 publish to fail. Strip monty dependency, python feature, and python_scripts example from Cargo.toml before `cargo publish` so the crate publishes without the python feature (which was already documented as unavailable from registry).
The strip step modifies Cargo.toml without committing, so cargo publish rejects the dirty working tree. --allow-dirty is correct here since the modification is intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo publishrejects the dirty tree--allow-dirtyflag — the modification is intentional (removing git-only monty dep)Test plan