fix(interpreter): apply brace/glob expansion in for-loop word list#211
Merged
fix(interpreter): apply brace/glob expansion in for-loop word list#211
Conversation
`for i in {0..5}` iterated once with literal `{0..5}` instead of
expanding to separate values. execute_for now applies expand_braces
and expand_glob to each word, matching execute_dispatched_command
behavior. Quoted words still skip expansion.
Closes #204 (supercedes — most of that PR landed via #201)
https://claude.ai/code/session_01VcvUwWMdEbp2qW3V1dyUDZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execute_fornow appliesexpand_bracesandexpand_globto each word in the for-loop word list, matchingexecute_dispatched_commandbehaviorfor i in {1..5}iterating once with literal{1..5}instead of expanding to1 2 3 4 5Test plan
cargo clippy --all-targets --all-features -- -D warningscleancargo test --all-features— all 14 test suites pass (594 spec cases, 99.8%+ pass rate)Closes #204