feat(bench): add parallel execution benchmark#29
Merged
Conversation
Adds criterion benchmark to test parallel Bash instance execution: - Compares sequential vs parallel execution (10-500 sessions) - Tests shared filesystem via Arc<dyn FileSystem> - Verifies threading model works as expected Results show ~2.5x speedup at 100 parallel sessions. https://claude.ai/code/session_01HkyPLLh8UTGfedhEbYKbLM
Adds test that verifies the benchmark script actually computes 1+2+3+4+5=15, proving the interpreter executes real work. https://claude.ai/code/session_01HkyPLLh8UTGfedhEbYKbLM
Replaces simple loop with real workloads: - Light: arithmetic loop (1+2+3+4+5) - Medium: log generation + grep + awk analysis - Heavy: 100 lines + grep + awk + sed transforms Results show 2-7x speedup for parallel execution. https://claude.ai/code/session_01HkyPLLh8UTGfedhEbYKbLM
Changes touching Arc, RwLock, Interpreter, FileSystem, async paths, or builtins must run benchmark and verify no regression. https://claude.ai/code/session_01HkyPLLh8UTGfedhEbYKbLM
- Created specs/007-parallel-execution.md with threading model, Arc usage, benchmark details - Condensed AGENTS.md to single Pre-PR checklist item referencing spec https://claude.ai/code/session_01HkyPLLh8UTGfedhEbYKbLM
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
crates/bashkit/benches/parallel_execution.rs- benchmark with light/medium/heavy workloadsspecs/007-parallel-execution.md- threading model and Arc usage docsAGENTS.md- pre-PR checklist item for perf benchmarksResults
Test plan
cargo bench --bench parallel_execution -- --testpassescargo clippyandcargo fmtclean