Conversation
…yle for loops Fixes 4 benchmark timeouts (arith_increment, ctrl_for_range, str_concat, complex_string_build): 1. Variable assignment with quoted strings (a="Hello"): - Updated lexer to include quoted strings as part of assignment words - Updated parser to strip quotes from scalar assignment values - Single-quoted values are treated as literals (no expansion) - Double-quoted values allow variable expansion 2. Arithmetic commands ((expression)): - Added DoubleLeftParen and DoubleRightParen tokens - Added CompoundCommand::Arithmetic variant - Parser now handles ((expression)) as standalone commands - Interpreter evaluates expressions with side effects (++, --, =, +=, etc.) 3. C-style for loops (for ((init; cond; step))): - Added ArithmeticForCommand AST type - Parser recognizes (( after 'for' keyword - Handles <, >, &&, || operators inside (( )) context - Interpreter executes init, checks condition, runs body, executes step
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a="Hello")((x++)))for ((i=0; i<5; i++)))Test plan
arith_increment: 0.017ms (was 1000ms timeout)ctrl_for_range: 0.019ms (was 1000ms timeout)str_concat: 0.014ms (was 1000ms timeout)complex_string_build: 0.018ms (was 1000ms timeout)