fix(interpreter): truncate exit codes to 8-bit range#365
Merged
Conversation
Bash truncates exit/return codes to unsigned 8-bit (0-255) via & 0xFF.
Bashkit was passing values >255 and negative values through unchanged.
Changes:
- exit builtin: truncate exit code with & 0xFF
- return builtin: truncate return code with & 0xFF
- Empty quoted command ('', ""): treat as "command not found" (exit 127)
instead of silently succeeding
Enable 9 previously-skipped spec tests from exit-status.test.sh.
Closes #356
https://claude.ai/code/session_018RLVEEcJBFYsxQKT5wYyNu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exitandreturncodes to 8-bit unsigned range (0-255) via& 0xFF, matching bash behavior'',"") as "command not found" (exit 127) instead of silently succeedingexit-status.test.shTest plan
exit 256-> 0,exit 257-> 1,exit -1-> 255,exit -2-> 254return 256-> 0,return 257-> 1,return -1-> 255,return -2-> 254if ''; then echo TRUE; else echo FALSE; fi-> FALSEcargo fmt,cargo clippycleanCloses #356