feat(security): add security tooling for vulnerability detection#43
Merged
feat(security): add security tooling for vulnerability detection#43
Conversation
Document security tools for vulnerability detection: - Static analysis: cargo-audit, cargo-deny, cargo-geiger - Dynamic analysis: cargo-fuzz, Miri, proptest - Memory safety: ASAN, Miri - Supply chain: cargo-audit, Dependabot Update testing coverage matrix to include fuzz and proptest columns.
- Add rustsec/audit-check action for CVE scanning - Add cargo-deny-action for license and source verification - Both run on every PR to catch security issues early
Add fuzz testing infrastructure: - parser_fuzz: Tests parser with arbitrary input - lexer_fuzz: Tests lexer/tokenizer - arithmetic_fuzz: Tests arithmetic expansion Add scheduled CI workflow that runs fuzzing nightly. Expose parser module publicly for fuzz target access. Addresses threat model V3 (parser hang) and V4 (parser recursion).
- Add Miri job for undefined behavior detection - Add cargo-geiger job for unsafe code auditing - Miri runs subset of parser tests (full suite too slow) - Geiger uploads report as artifact for review Note: No unsafe code currently in bashkit crate.
Add property-based tests that verify: - Parser/lexer never panic on arbitrary input - Execution always terminates with limits - Nested structures don't cause stack overflow - Resource limits are enforced - Path traversal attempts are contained - Variable expansion is safe Run in CI with reduced cases for speed, full suite in nightly.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The cargo-deny check was failing because: - colored crate uses MPL-2.0 - icu_* crates use Unicode-3.0 Both are OSI-approved licenses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive security tooling to BashKit for vulnerability detection and prevention:
Changes
Test plan
cargo fmt --checkpassescargo clippy --all-targets --all-features -- -D warningspassescargo test --features networkpasses (288 tests)cargo test --test proptest_securitypasses