Conversation
Add comprehensive Unicode security analysis (TM-UNI-001 through TM-UNI-014) covering byte-boundary panics, zero-width character injection, homoglyphs, normalization bypass, combining character abuse, tag character hiding, and bidi attacks in script source. Includes 37 security tests. Key findings: - TM-UNI-001/002 (MEDIUM): awk/sed parsers use char position as byte offset, causing panics on multi-byte UTF-8. catch_unwind prevents process crash but builtins silently fail on valid Unicode input (issue #395). - TM-UNI-003/011-013 (LOW, UNMITIGATED): find_unsafe_path_char() does not reject zero-width chars, tag chars, or deprecated format chars in filenames. - TM-UNI-004-008/014 (ACCEPTED): Homoglyphs, normalization, bidi in scripts match Bash/Linux behavior; impractical or out-of-scope to detect. Updates specs/006-threat-model.md and crates/bashkit/docs/threat-model.md. https://claude.ai/code/session_01UyZS8g5xbhbBwApxqS4evf
Codebase-wide Unicode security audit found byte/char confusion in 5 additional components beyond awk/sed. Added TM-UNI-015 through TM-UNI-019 covering expr, printf, cut/tr, interpreter arithmetic, and network allowlist. Added 31 new security tests (68 total) and documented safe components confirmed by audit (lexer, wc, grep, jq, sort/uniq, logging). https://claude.ai/code/session_01UyZS8g5xbhbBwApxqS4evf
…-UNI - Link TM-UNI-015 through TM-UNI-019 to issues #434-#438 - Add comprehensive safe-component list from full codebase audit: python.rs, bashkit-python, eval harness, curl, bc, export, date, comm, echo, archive, base64, scripted_tool — all verified safe - Update both specs/006-threat-model.md and docs/threat-model.md https://claude.ai/code/session_01UyZS8g5xbhbBwApxqS4evf
…atus Add security test section documenting 68 unicode byte-boundary tests across 13 categories covering all affected components. https://claude.ai/code/session_01UyZS8g5xbhbBwApxqS4evf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unicode_security_tests.rs— 13 expose actual panics caught bycatch_unwindTest plan
cargo test --test unicode_security_tests)cargo fmt --checkcleancargo clippyclean