chore: adopt ship command and shipping definition#441
Merged
Conversation
Add /ship command adapted from everruns for bashkit's tooling (cargo/just, no UI/server, bashkit-specific smoke testing). Add "Shipping" definition to AGENTS.md. https://claude.ai/code/session_01Lbmx1UUYMfUkV5pL8Bw2v4
Function only used under http_client feature but lacked the gate, causing dead-code warning. https://claude.ai/code/session_01Lbmx1UUYMfUkV5pL8Bw2v4
Add Phase 3b (code simplification) and Phase 3c (security review) to the shipping workflow, ensuring changed code is reviewed for duplication, complexity, and security vulnerabilities before merge. https://claude.ai/code/session_01Lbmx1UUYMfUkV5pL8Bw2v4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
/shipcommand and "Shipping" definition to bashkit, adopted from everruns/everruns.Why
Standardize the shipping workflow so agents follow a consistent quality-gated flow: test coverage, artifact updates, smoke testing, quality gates, PR, CI, merge.
How
.claude/commands/ship.md: 8-phase ship command adapted for bashkit's tooling (cargo/just, no UI/server, bashkit-specific smoke testing paths)AGENTS.md: Added "Shipping" section defining what "ship" means and pointing to/shipcommandcrates/bashkit/src/builtins/curl.rs: Fixed pre-existing clippy dead-code warning by adding missing#[cfg(feature = "http_client")]gate onresolve_redirect_urlRisk
Low — markdown/workflow files + trivial cfg gate fix.
Checklist
cargo fmt --checkpassescargo clippy --all-targets -- -D warningspassesjust testpasses (all tests green)