fix(fs): prevent usage double-counting in OverlayFs#457
Merged
Conversation
chaliy
force-pushed
the
claude/fix-418-Y2nIj
branch
from
85dac6d to
66fa2da
Compare
compute_usage() previously summed upper + lower layer usage without deducting overwritten or whited-out files. Add lower_hidden accumulator that tracks hidden lower entries incrementally in write_file, remove, append_file, and chmod. compute_usage now subtracts the hidden portion from the lower contribution. Closes #418 https://claude.ai/code/session_01WZjYqxm5xMPAEe7FSHJkDy
chaliy
force-pushed
the
claude/fix-418-Y2nIj
branch
from
66fa2da to
b40a300
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lower_hiddenaccumulatorcompute_usage()to avoid double-countingTest plan
test_usage_no_double_count_override- overriding a file doesn't inflate counttest_usage_deducts_whiteouts- deleting a lower file deducts its usagetest_usage_no_double_count_append_cow- CoW append adds only new bytesCloses #418