test(security): deep security audit with regression tests#487
Merged
Conversation
Comprehensive security audit covering parser, VFS, builtins, Python
integration, tool interface, and network boundaries. Found 18 new
vulnerabilities (TM-INJ-012–016, TM-INF-017–018, TM-DOS-041–050,
TM-PY-028) with working PoC tests. Also verified 3 previously-open
issues are now fixed (TM-DOS-030, TM-INF-013, TM-INF-014).
Key findings:
- declare/readonly/local/export bypass is_internal_variable() guard
- _ARRAY_READ_ prefix injection creates arbitrary arrays
- Brace expansion {N..M} has no upper bound (OOM DoS)
- Arithmetic compound assignment panics on overflow (DoS)
- Lexer stack overflow on nested $() in double-quotes
- OverlayFs symlink() bypasses all file count limits
- InMemoryFs copy() skips limits when dest exists
- date builtin leaks real host time
https://claude.ai/code/session_01JuqQfhfg67dWWn8ngcBxUK
Tests now assert desired secure behavior and are #[ignore] until fixes land. Each ignore reason includes the threat model ID. When a fix is applied, the test flips from ignored→green as a regression gate. - 16 ignored tests: all fail when forced (confirming vulns are present) - 1 non-ignored test: lexer depth at safe level (documents safe path) - CI runs clean: clippy, tests, no warnings https://claude.ai/code/session_01JuqQfhfg67dWWn8ngcBxUK
This was referenced Mar 2, 2026
Closed
Bump aws-lc-rs exemption 1.16.0 → 1.16.1 and aws-lc-sys 0.37.1 → 0.38.0 to match Cargo.lock, fixing cargo-vet Audit CI failure. https://claude.ai/code/session_01JuqQfhfg67dWWn8ngcBxUK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[ignore]until fix lands, 1 active) insecurity_audit_pocs.rsspecs/006-threat-model.mdwith new threat IDs, fixed statuses, and open controlsKey findings
Test plan
cargo test --test security_audit_pocs— 1 pass, 16 ignored, 0 failurescargo test --test security_audit_pocs -- --ignored— all 16 fail (confirming vulns present)cargo clippy --all-targets --all-features -- -D warnings— cleancargo test --features http_client --test security_audit_pocs— passes with CI flags