feat(parser): add fuel-based operation limit to prevent DoS#66
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1a98180 to
db53737
Compare
Add parser fuel tracking to prevent CPU exhaustion from pathological input:
- Parser tracks fuel consumption on every token advance
- Default limit: 100,000 operations (matches ExecutionLimits)
- Parser::with_fuel() constructor for custom limits
- Bash::exec() uses configured limits from ExecutionLimits
- Error: Parse("parser fuel exhausted (N operations, max M)")
Security: Prevents V3 (Parser Hang) attacks from threat model.
https://claude.ai/code/session_018gzyudqmPsjaDgCxmKVLtg
db53737 to
26bea6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_parser_operationsfield to ExecutionLimits (default: 100,000)ParserExhaustedvariant to LimitExceeded error enumSecurity: Prevents V3 (Parser Hang) attacks from threat model by limiting parser CPU consumption.
Test plan
cargo test- all tests passcargo clippy- no warningshttps://claude.ai/code/session_018gzyudqmPsjaDgCxmKVLtg