fix: resolve cargo doc collision and rustdoc warnings#71
Merged
Conversation
The binary target `bashkit` in bashkit-cli was colliding with the library crate `bashkit` when generating documentation, both outputting to /target/doc/bashkit/index.html. Setting `doc = false` on the binary target resolves this since the CLI is just a thin wrapper and the library contains the actual API docs. https://claude.ai/code/session_01LNHxiWJ83at7dSeCMi8Bax
- Remove doc link to private `fs` module in lib.rs - Escape brackets in array syntax examples in ast.rs - Wrap bare URLs in backticks in allowlist.rs https://claude.ai/code/session_01LNHxiWJ83at7dSeCMi8Bax
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo doc --no-depscompletes without warningshttps://claude.ai/code/session_01LNHxiWJ83at7dSeCMi8Bax