Skip to content

chore(skills): add design quality review phase to ship command#749

Merged
chaliy merged 1 commit intomainfrom
claude/add-code-review-section-yvMk3
Mar 18, 2026
Merged

chore(skills): add design quality review phase to ship command#749
chaliy merged 1 commit intomainfrom
claude/add-code-review-section-yvMk3

Conversation

@chaliy
Copy link
Copy Markdown
Contributor

@chaliy chaliy commented Mar 18, 2026

What

Adds Phase 3d (Design Quality Review) to the /ship skill, inserting it between Security Review (3c) and Smoke Testing (4).

Why

This is a greenfield project where clean design matters more than compatibility. The new phase catches shortcuts, lazy abstractions, and premature compromises before they ship — enforcing 8 specific review checkpoints covering abstraction quality, type safety, error design, and module boundaries.

How

Added a new markdown section to .claude/commands/ship.md with 8 review criteria:

  1. No shortcut abstractions
  2. No lazy wrappers
  3. Right abstraction level
  4. No stringly-typed interfaces
  5. No premature generics
  6. No compatibility shims
  7. First-class error types
  8. Module boundaries enforce invariants

Tests

  • Documentation-only change, no code tests needed
  • just pre-pr passes (fmt, clippy, all tests green)

Add Phase 3d covering shortcuts, lazy abstractions, and premature
compromises. Greenfield project needs clean design over compatibility.
@chaliy chaliy merged commit c2e6459 into main Mar 18, 2026
11 checks passed
@chaliy chaliy deleted the claude/add-code-review-section-yvMk3 branch March 18, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant