refactor(builtins): replace magic variable hack with BuiltinSideEffect enum#750
Merged
refactor(builtins): replace magic variable hack with BuiltinSideEffect enum#750
Conversation
…t enum Introduce BuiltinSideEffect enum on ExecResult for builtins to communicate state changes to the interpreter via a typed channel instead of smuggling data through magic-prefixed variables in the HashMap. Migrated: Set (_SET_POSITIONAL), Shift (_SHIFT_COUNT), Read -a (_ARRAY_READ_*). Remaining magic vars (_NAMEREF_, _READONLY_, etc.) are still in use and will be migrated in follow-up work. Closes #728
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuiltinSideEffectenum onExecResultas a typed channel for builtins to communicate state changes to the interpreterSet(_SET_POSITIONAL),Shift(_SHIFT_COUNT), andRead -a(_ARRAY_READ_*) from magic-prefixed variables to structured side effectsapply_builtin_side_effects()method to interpreter that processes the enum variantsis_internal_variable()still blocks all legacy prefixesCloses #728
Test plan
read -aarray tests updated to verify side effectscargo fmt --checkandcargo clippyclean