feat(fs): restore SearchCapable/SearchProvider traits#779
Merged
Conversation
Reverts the removal from #755 and restores the SearchCapable/SearchProvider traits as public API surface. These traits allow filesystem implementations to provide indexed search, with grep builtin checking at runtime and falling back to linear scan when unavailable. - Restore fs/search.rs with SearchCapable, SearchProvider, SearchQuery, SearchResults, SearchMatch, SearchCapabilities types - Re-add as_search_capable() default method on FileSystem trait - Re-add try_indexed_search() in grep builtin for indexed search path - Re-export all search types from lib.rs public API - Add comprehensive tests: edge cases, error handling, path-scoped providers, capability variations, clone/debug impls - Add rustdoc with full working example showing how to implement a custom SearchCapable filesystem Closes #658 Reopens #739 functionality
chaliy
force-pushed
the
claude/revert-search-traits-IwqLE
branch
from
64dc993 to
9344358
Compare
yonas
pushed a commit
to yonasBSD/bashkit
that referenced
this pull request
Mar 22, 2026
## Summary - Bump version to 0.1.12 - Update CHANGELOG.md with 4 PRs since v0.1.11 ### What's Changed * feat(fs): restore SearchCapable/SearchProvider traits (everruns#779) * refactor(builtins): adopt read_text_file helper across 17 builtins (everruns#778) * chore(skills): move repo skills under .agents (everruns#777) * refactor(builtins): share lossy text file reads (everruns#775) ## Test plan - [x] `cargo fmt --check` passes - [x] `cargo clippy --all-targets --all-features -- -D warnings` passes - [x] `cargo test --all-features` passes - [ ] CI green on PR - [ ] Merge triggers release.yml to create GitHub Release v0.1.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SearchCapable/SearchProvidertraits removed in refactor(fs): remove dead SearchCapable/SearchProvider traits #755, as required by feat(fs): optional SearchCapable trait for indexed filesystem search #658as_search_capable()default method onFileSystemtraittry_indexed_search()in grep builtin for indexed search fast-pathSearchQuery,SearchResults,SearchMatch,SearchCapabilities) re-exported fromlib.rspublic APISearchCapablefilesystemTest plan
SearchCapableimplementation examplecargo fmt --checkcleancargo clippy --all-targets --all-features -- -D warningsclean