feat(grep): implement missing grep flags (-A/-B/-C, -m, -q, -x, -e)#80
Merged
feat(grep): implement missing grep flags (-A/-B/-C, -m, -q, -x, -e)#80
Conversation
Implements the following grep features that were listed as missing in KNOWN_LIMITATIONS.md: - Context flags: -A (after), -B (before), -C (context) - Max count flag: -m N (stop after N matches) - Quiet mode: -q (exit status only, no output) - Whole line match: -x (match entire line) - Multiple patterns: -e pat1 -e pat2 (OR matching) Also adds comprehensive test coverage: - 15 new test cases for new features - Tests for edge cases (overlapping context, max count with context) - Negative tests (no match scenarios) Updates documentation: - KNOWN_LIMITATIONS.md: Updated grep section, test counts (55→70 cases) - specs/005-builtins.md: Added new grep flags to documentation https://claude.ai/code/session_01C1QHWwiXoRxfaBx6YMLoFa
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Fix cargo-vet failure due to insta version bump. https://claude.ai/code/session_01C1QHWwiXoRxfaBx6YMLoFa
…guration Fix cargo-vet failures due to dependency updates. https://claude.ai/code/session_01C1QHWwiXoRxfaBx6YMLoFa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-A,-B,-Cfor showing lines around matches-m Nto stop after N matches-qfor exit status only (no output)-xfor matching entire lines-e pat1 -e pat2for OR matchingChanges
Test plan